Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 593113004: Remove implicit HANDLE conversions from base. (Closed)

Created:
6 years, 3 months ago by rvargas (doing something else)
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, wfh+watch_chromium.org, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit HANDLE conversions from base. BUG=416722 R=brettw@chromium.org Committed: https://crrev.com/ecaef8a307d1bc5e48adbdc9234c92c902b8843b Cr-Commit-Position: refs/heads/master@{#296276}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -60 lines) Patch
M base/debug/gdi_debug_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/files/file_util_win.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M base/files/file_win.cc View 12 chunks +16 lines, -15 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M base/message_loop/message_pump_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/sync_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_win.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 5 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rvargas (doing something else)
6 years, 3 months ago (2014-09-23 18:58:28 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-23 20:12:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593113004/20001
6 years, 3 months ago (2014-09-23 21:13:46 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 424760dc9a6e9b8481ff8c5713467c687091461f
6 years, 3 months ago (2014-09-23 22:03:20 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 22:04:13 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ecaef8a307d1bc5e48adbdc9234c92c902b8843b
Cr-Commit-Position: refs/heads/master@{#296276}

Powered by Google App Engine
This is Rietveld 408576698