Remove implicit HANDLE conversions from base.

base/files/file_util_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util.h"
 
 #include <windows.h>
 #include <io.h>
 #include <psapi.h>
 #include <shellapi.h>
@@ skipping 486 matching lines @@
   // function uses is explained in the following msdn article:
   // http://msdn.microsoft.com/en-us/library/aa366789(VS.85).aspx
   base::win::ScopedHandle file_handle(
       ::CreateFile(path.value().c_str(),
                    GENERIC_READ,
                    kFileShareAll,
                    NULL,
                    OPEN_EXISTING,
                    FILE_ATTRIBUTE_NORMAL,
                    NULL));
-  if (!file_handle)
+  if (!file_handle.IsValid())
     return false;
 
   // Create a file mapping object.  Can't easily use MemoryMappedFile, because
   // we only map the first byte, and need direct access to the handle. You can
   // not map an empty file, this call fails in that case.
   base::win::ScopedHandle file_map_handle(
       ::CreateFileMapping(file_handle.Get(),
                           NULL,
                           PAGE_READONLY,
                           0,
                           1,  // Just one byte.  No need to look at the data.
                           NULL));
-  if (!file_map_handle)
+  if (!file_map_handle.IsValid())
     return false;
 
   // Use a view of the file to get the path to the file.
   void* file_view = MapViewOfFile(file_map_handle.Get(),
                                   FILE_MAP_READ, 0, 0, 1);
   if (!file_view)
     return false;
 
   // The expansion of |path| into a full path may make it longer.
   // GetMappedFileName() will fail if the result is longer than MAX_PATH.
@@ skipping 64 matching lines @@
 
 int ReadFile(const FilePath& filename, char* data, int max_size) {
   ThreadRestrictions::AssertIOAllowed();
   base::win::ScopedHandle file(CreateFile(filename.value().c_str(),
                                           GENERIC_READ,
                                           FILE_SHARE_READ | FILE_SHARE_WRITE,
                                           NULL,
                                           OPEN_EXISTING,
                                           FILE_FLAG_SEQUENTIAL_SCAN,
                                           NULL));
-  if (!file)
+  if (!file.IsValid())
     return -1;
 
   DWORD read;
-  if (::ReadFile(file, data, max_size, &read, NULL))
+  if (::ReadFile(file.Get(), data, max_size, &read, NULL))
     return read;
 
   return -1;
 }
 
 int WriteFile(const FilePath& filename, const char* data, int size) {
   ThreadRestrictions::AssertIOAllowed();
   base::win::ScopedHandle file(CreateFile(filename.value().c_str(),
                                           GENERIC_WRITE,
                                           0,
                                           NULL,
                                           CREATE_ALWAYS,
                                           0,
                                           NULL));
-  if (!file) {
+  if (!file.IsValid()) {
     DPLOG(WARNING) << "CreateFile failed for path "
                    << UTF16ToUTF8(filename.value());
     return -1;
   }
 
   DWORD written;
-  BOOL result = ::WriteFile(file, data, size, &written, NULL);
+  BOOL result = ::WriteFile(file.Get(), data, size, &written, NULL);
   if (result && static_cast<int>(written) == size)
     return written;
 
   if (!result) {
     // WriteFile failed.
     DPLOG(WARNING) << "writing file " << UTF16ToUTF8(filename.value())
                    << " failed";
   } else {
     // Didn't write all the bytes.
     DLOG(WARNING) << "wrote" << written << " bytes to "
                   << UTF16ToUTF8(filename.value()) << " expected " << size;
   }
   return -1;
 }
 
 int AppendToFile(const FilePath& filename, const char* data, int size) {
   ThreadRestrictions::AssertIOAllowed();
   base::win::ScopedHandle file(CreateFile(filename.value().c_str(),
                                           FILE_APPEND_DATA,
                                           0,
                                           NULL,
                                           OPEN_EXISTING,
                                           0,
                                           NULL));
-  if (!file) {
+  if (!file.IsValid()) {
     DPLOG(WARNING) << "CreateFile failed for path "
                    << UTF16ToUTF8(filename.value());
     return -1;
   }
 
   DWORD written;
-  BOOL result = ::WriteFile(file, data, size, &written, NULL);
+  BOOL result = ::WriteFile(file.Get(), data, size, &written, NULL);
   if (result && static_cast<int>(written) == size)
     return written;
 
   if (!result) {
     // WriteFile failed.
     DPLOG(WARNING) << "writing file " << UTF16ToUTF8(filename.value())
                    << " failed";
   } else {
     // Didn't write all the bytes.
     DLOG(WARNING) << "wrote" << written << " bytes to "
@@ skipping 127 matching lines @@
     // Like Move, this function is not transactional, so we just
     // leave the copied bits behind if deleting from_path fails.
     // If to_path exists previously then we have already overwritten
     // it by now, we don't get better off by deleting the new bits.
   }
   return false;
 }
 
 }  // namespace internal
 }  // namespace base