base/sync_socket_win.cc - Issue 593113004: Remove implicit HANDLE conversions from base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/sync_socket_win.cc

Issue 593113004: Remove implicit HANDLE conversions from base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/sync_socket_win.cc

diff --git a/base/sync_socket_win.cc b/base/sync_socket_win.cc

index 6b2575c2f691f99c72a95c9cd478aba0ccb6e349..c07e62a6120d9a4f837b4690e5c1d34fd9b494b8 100644

--- a/base/sync_socket_win.cc

+++ b/base/sync_socket_win.cc

@@ -85,7 +85,7 @@ bool CreatePairImpl(HANDLE* socket_a, HANDLE* socket_b, bool overlapped) {

return false;

}

- if (!ConnectNamedPipe(handle_a, NULL)) {

+ if (!ConnectNamedPipe(handle_a.Get(), NULL)) {

DWORD error = GetLastError();

if (error != ERROR_PIPE_CONNECTED) {

DPLOG(ERROR) << "ConnectNamedPipe failed";

« no previous file with comments | « base/message_loop/message_pump_win.cc ('k') | base/test/test_file_util_win.cc » ('j') | no next file with comments »