base/debug/gdi_debug_util_win.cc - Issue 593113004: Remove implicit HANDLE conversions from base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/gdi_debug_util_win.cc

Issue 593113004: Remove implicit HANDLE conversions from base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/gdi_debug_util_win.cc

diff --git a/base/debug/gdi_debug_util_win.cc b/base/debug/gdi_debug_util_win.cc

index 4bac759d8c78568e86e374deb6247dcd5fbc4508..ddd410613be328a8654b8a822187666a925aa4cf 100644

--- a/base/debug/gdi_debug_util_win.cc

+++ b/base/debug/gdi_debug_util_win.cc

@@ -41,7 +41,7 @@ void CollectChildGDIUsageAndDie(DWORD parent_pid) {

::OpenProcess(PROCESS_QUERY_INFORMATION,

FALSE,

proc_entry.th32ParentProcessID));

- if (!process)

+ if (!process.IsValid())

continue;

int num_gdi_handles = ::GetGuiResources(process.Get(), GR_GDIOBJECTS);

« no previous file with comments | « no previous file | base/files/file_util_unittest.cc » ('j') | no next file with comments »