Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 592113002: Fix method dispatch in Keyed/StoreIC, and JumpIfNotUniqueName usage (Closed)

Created:
6 years, 2 months ago by Jakob Kummerow
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix method dispatch in Keyed/StoreIC, and JumpIfNotUniqueName usage R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -106 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ic/ic.h View 4 chunks +4 lines, -24 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +32 lines, -3 lines 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jakob Kummerow
As discussed.
6 years, 2 months ago (2014-09-22 15:35:28 UTC) #2
Igor Sheludko
lgtm
6 years, 2 months ago (2014-09-23 09:02:14 UTC) #4
Jakob Kummerow
6 years, 2 months ago (2014-09-23 09:21:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 24139 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698