Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1844)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 592113002: Fix method dispatch in Keyed/StoreIC, and JumpIfNotUniqueName usage (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/macro-assembler-arm.h ('k') | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits.h> // For LONG_MIN, LONG_MAX. 5 #include <limits.h> // For LONG_MIN, LONG_MAX.
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_ARM 9 #if V8_TARGET_ARCH_ARM
10 10
(...skipping 3181 matching lines...) Expand 10 before | Expand all | Expand 10 after
3192 Register scratch2, 3192 Register scratch2,
3193 Label* failure) { 3193 Label* failure) {
3194 // Check that neither is a smi. 3194 // Check that neither is a smi.
3195 and_(scratch1, first, Operand(second)); 3195 and_(scratch1, first, Operand(second));
3196 JumpIfSmi(scratch1, failure); 3196 JumpIfSmi(scratch1, failure);
3197 JumpIfNonSmisNotBothSequentialOneByteStrings(first, second, scratch1, 3197 JumpIfNonSmisNotBothSequentialOneByteStrings(first, second, scratch1,
3198 scratch2, failure); 3198 scratch2, failure);
3199 } 3199 }
3200 3200
3201 3201
3202 void MacroAssembler::JumpIfNotUniqueName(Register reg, 3202 void MacroAssembler::JumpIfNotUniqueNameInstanceType(Register reg,
3203 Label* not_unique_name) { 3203 Label* not_unique_name) {
3204 STATIC_ASSERT(kInternalizedTag == 0 && kStringTag == 0); 3204 STATIC_ASSERT(kInternalizedTag == 0 && kStringTag == 0);
3205 Label succeed; 3205 Label succeed;
3206 tst(reg, Operand(kIsNotStringMask | kIsNotInternalizedMask)); 3206 tst(reg, Operand(kIsNotStringMask | kIsNotInternalizedMask));
3207 b(eq, &succeed); 3207 b(eq, &succeed);
3208 cmp(reg, Operand(SYMBOL_TYPE)); 3208 cmp(reg, Operand(SYMBOL_TYPE));
3209 b(ne, not_unique_name); 3209 b(ne, not_unique_name);
3210 3210
3211 bind(&succeed); 3211 bind(&succeed);
3212 } 3212 }
3213 3213
(...skipping 868 matching lines...) Expand 10 before | Expand all | Expand 10 after
4082 sub(result, result, Operand(dividend)); 4082 sub(result, result, Operand(dividend));
4083 } 4083 }
4084 if (mag.shift > 0) mov(result, Operand(result, ASR, mag.shift)); 4084 if (mag.shift > 0) mov(result, Operand(result, ASR, mag.shift));
4085 add(result, result, Operand(dividend, LSR, 31)); 4085 add(result, result, Operand(dividend, LSR, 31));
4086 } 4086 }
4087 4087
4088 4088
4089 } } // namespace v8::internal 4089 } } // namespace v8::internal
4090 4090
4091 #endif // V8_TARGET_ARCH_ARM 4091 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/macro-assembler-arm.h ('k') | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698