Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: src/ic/arm64/ic-compiler-arm64.cc

Issue 592113002: Fix method dispatch in Keyed/StoreIC, and JumpIfNotUniqueName usage (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic/arm/ic-compiler-arm.cc ('k') | src/ic/ia32/ic-compiler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/ic/ic-compiler.h" 10 #include "src/ic/ic-compiler.h"
(...skipping 27 matching lines...) Expand all
38 Handle<Name> name, 38 Handle<Name> name,
39 Code::StubType type, 39 Code::StubType type,
40 IcCheckType check) { 40 IcCheckType check) {
41 Label miss; 41 Label miss;
42 42
43 if (check == PROPERTY && 43 if (check == PROPERTY &&
44 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) { 44 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) {
45 // In case we are compiling an IC for dictionary loads and stores, just 45 // In case we are compiling an IC for dictionary loads and stores, just
46 // check whether the name is unique. 46 // check whether the name is unique.
47 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) { 47 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) {
48 __ JumpIfNotUniqueName(this->name(), &miss); 48 Register tmp = scratch1();
49 __ JumpIfSmi(this->name(), &miss);
50 __ Ldr(tmp, FieldMemOperand(this->name(), HeapObject::kMapOffset));
51 __ Ldrb(tmp, FieldMemOperand(tmp, Map::kInstanceTypeOffset));
52 __ JumpIfNotUniqueNameInstanceType(tmp, &miss);
49 } else { 53 } else {
50 __ CompareAndBranch(this->name(), Operand(name), ne, &miss); 54 __ CompareAndBranch(this->name(), Operand(name), ne, &miss);
51 } 55 }
52 } 56 }
53 57
54 Label number_case; 58 Label number_case;
55 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss; 59 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss;
56 __ JumpIfSmi(receiver(), smi_target); 60 __ JumpIfSmi(receiver(), smi_target);
57 61
58 // Polymorphic keyed stores may use the map register 62 // Polymorphic keyed stores may use the map register
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 124
121 return GetCode(kind(), Code::NORMAL, factory()->empty_string(), POLYMORPHIC); 125 return GetCode(kind(), Code::NORMAL, factory()->empty_string(), POLYMORPHIC);
122 } 126 }
123 127
124 128
125 #undef __ 129 #undef __
126 } 130 }
127 } // namespace v8::internal 131 } // namespace v8::internal
128 132
129 #endif // V8_TARGET_ARCH_ARM64 133 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/ic/arm/ic-compiler-arm.cc ('k') | src/ic/ia32/ic-compiler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698