Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: src/ic/x64/ic-compiler-x64.cc

Issue 592113002: Fix method dispatch in Keyed/StoreIC, and JumpIfNotUniqueName usage (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic/mips64/ic-compiler-mips64.cc ('k') | src/ic/x87/ic-compiler-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/ic/ic-compiler.h" 10 #include "src/ic/ic-compiler.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 Handle<Name> name, 75 Handle<Name> name,
76 Code::StubType type, 76 Code::StubType type,
77 IcCheckType check) { 77 IcCheckType check) {
78 Label miss; 78 Label miss;
79 79
80 if (check == PROPERTY && 80 if (check == PROPERTY &&
81 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) { 81 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) {
82 // In case we are compiling an IC for dictionary loads and stores, just 82 // In case we are compiling an IC for dictionary loads and stores, just
83 // check whether the name is unique. 83 // check whether the name is unique.
84 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) { 84 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) {
85 __ JumpIfNotUniqueName(this->name(), &miss); 85 Register tmp = scratch1();
86 __ JumpIfSmi(this->name(), &miss);
87 __ movp(tmp, FieldOperand(this->name(), HeapObject::kMapOffset));
88 __ movzxbp(tmp, FieldOperand(tmp, Map::kInstanceTypeOffset));
89 __ JumpIfNotUniqueNameInstanceType(tmp, &miss);
86 } else { 90 } else {
87 __ Cmp(this->name(), name); 91 __ Cmp(this->name(), name);
88 __ j(not_equal, &miss); 92 __ j(not_equal, &miss);
89 } 93 }
90 } 94 }
91 95
92 Label number_case; 96 Label number_case;
93 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss; 97 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss;
94 __ JumpIfSmi(receiver(), smi_target); 98 __ JumpIfSmi(receiver(), smi_target);
95 99
(...skipping 28 matching lines...) Expand all
124 number_of_handled_maps > 1 ? POLYMORPHIC : MONOMORPHIC; 128 number_of_handled_maps > 1 ? POLYMORPHIC : MONOMORPHIC;
125 return GetCode(kind(), type, name, state); 129 return GetCode(kind(), type, name, state);
126 } 130 }
127 131
128 132
129 #undef __ 133 #undef __
130 } 134 }
131 } // namespace v8::internal 135 } // namespace v8::internal
132 136
133 #endif // V8_TARGET_ARCH_X64 137 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ic/mips64/ic-compiler-mips64.cc ('k') | src/ic/x87/ic-compiler-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698