Added the detailed description for MSVC warning in BUILD.gn

Added the detailed  description for MSVC warning in BUILD.gn

BUG=

Committed: https://crrev.com/59a0e353d7eccbab5b8238e11fe555932eb54b03
Cr-Commit-Position: refs/heads/master@{#296633}

[ARUNKK, 2014-09-19 15:02:17]

kulkarni.a@samsung.com changed reviewers:
+ rmistry@google.com

[ARUNKK, 2014-09-19 15:02:18]

PTAL.

[ARUNKK, 2014-09-19 15:03:57]

kulkarni.a@samsung.com changed reviewers:
+ brettw@chromium.org

[ARUNKK, 2014-09-19 15:03:58]

Added the detailed description for MSVC warning suppression as per the TODO in
BUILD.gn

[brettw, 2014-09-19 20:46:22]

https://codereview.chromium.org/588603002/diff/1/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/588603002/diff/1/skia/BUILD.gn#newcode237
skia/BUILD.gn:237: # TODO(brettw) comment what these are.
Remove todo.

https://codereview.chromium.org/588603002/diff/1/skia/BUILD.gn#newcode238
skia/BUILD.gn:238: "/wd4244", # To suppress the warning conversion' conversion
from 'type1( __int64)' to 'type2 (unsigned int)', possible loss of data
You can remove "to suppress the warning" on every line. If any of them are still
>80 cols, can you shorten them until they fit? The descriptions don't need to be
super detailed.

[ARUNKK, 2014-09-20 08:51:07]

On 2014/09/19 20:46:22, brettw wrote:
> https://codereview.chromium.org/588603002/diff/1/skia/BUILD.gn
> File skia/BUILD.gn (right):
> 
> https://codereview.chromium.org/588603002/diff/1/skia/BUILD.gn#newcode237
> skia/BUILD.gn:237: # TODO(brettw) comment what these are.
> Remove todo.
> 
> https://codereview.chromium.org/588603002/diff/1/skia/BUILD.gn#newcode238
> skia/BUILD.gn:238: "/wd4244", # To suppress the warning conversion' conversion
> from 'type1( __int64)' to 'type2 (unsigned int)', possible loss of data
> You can remove "to suppress the warning" on every line. If any of them are
still
> >80 cols, can you shorten them until they fit? The descriptions don't need to
be
> super detailed.

PTAL.

[brettw, 2014-09-20 13:42:09]

80 cols still? Also, I'm not an owner of this directory, you'll probably need a
skia owner.

[ARUNKK, 2014-09-22 04:45:14]

On 2014/09/20 13:42:09, brettw (no non-GN reviews plz) wrote:
> 80 cols still? Also, I'm not an owner of this directory, you'll probably need
a
> skia owner
Incorporated the Review comments.
PTAL.

[brettw, 2014-09-22 04:46:11]

lgtm

[ARUNKK, 2014-09-22 04:47:15]

The CQ bit was checked by kulkarni.a@samsung.com

[commit-bot: I haz the power, 2014-09-22 04:47:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588603002/30001

[ARUNKK, 2014-09-22 04:48:28]

On 2014/09/22 04:46:11, brettw (no non-GN reviews plz) wrote:
> lgtm

Thanks for LGTM.

[commit-bot: I haz the power, 2014-09-22 04:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 04:56:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ARUNKK, 2014-09-22 06:17:19]

kulkarni.a@samsung.com changed reviewers:
+ thakis@chromium.org

[ARUNKK, 2014-09-24 07:02:07]

On 2014/09/22 04:56:28, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    skia/BUILD.gn

Please review from skia owners.

[Nico, 2014-09-24 16:44:05]

lgtm

[ARUNKK, 2014-09-25 02:54:10]

The CQ bit was checked by kulkarni.a@samsung.com

[commit-bot: I haz the power, 2014-09-25 02:54:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588603002/30001

[commit-bot: I haz the power, 2014-09-25 03:21:29]

Committed patchset #3 (id:30001) as aeec66ddef5b44ab0a2d1456b775c38c088d3513

[commit-bot: I haz the power, 2014-09-25 03:22:05]

Patchset 3 (id:??) landed as
https://crrev.com/59a0e353d7eccbab5b8238e11fe555932eb54b03
Cr-Commit-Position: refs/heads/master@{#296633}