Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: skia/BUILD.gn

Issue 588603002: Added the detailed description for MSVC warning in BUILD.gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments made 80 columns. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index 8cf9fa4d5ab5c6763a99705b1f3f250015155087..1bf626ce4bc7fa092497d582d7167be3ee226295 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -234,15 +234,15 @@ config("skia_library_config") {
defines += [ "SK_FONTHOST_USES_FONTMGR" ]
cflags = [
- # TODO(brettw) comment what these are.
- "/wd4244",
- "/wd4267",
- "/wd4341",
- "/wd4345",
- "/wd4390",
- "/wd4554",
- "/wd4748",
- "/wd4800",
+ "/wd4244", # conversion from 'type1( __int64)' to 'type2 (unsigned int)'
+ "/wd4267", # conversion from 'size_t' (64 bit) to 'type'(32 bit).
+ "/wd4341", # signed value is out of range for enum constant.
+ "/wd4345", # Object is default-initialized if initialization is omitted.
+ "/wd4390", # ';'empty statement found in looping;is it what was intended?
+ "/wd4554", # 'operator' : check operator precedence for possible error
+ "/wd4748", # compiler will disable optimizations if a function has inline
+ # assembly code contains flow control(jmp or jcc) statements.
+ "/wd4800", # forcing value to bool 'true/false'(assigning int to bool).
]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698