Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: skia/BUILD.gn

Issue 588603002: Added the detailed description for MSVC warning in BUILD.gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments made 80 columns. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 if (cpu_arch == "arm") { 7 if (cpu_arch == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 10
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 227
228 if (is_win) { 228 if (is_win) {
229 include_dirs = [ 229 include_dirs = [
230 "//third_party/skia/include/utils/win", 230 "//third_party/skia/include/utils/win",
231 "//third_party/skia/src/utils/win", 231 "//third_party/skia/src/utils/win",
232 ] 232 ]
233 233
234 defines += [ "SK_FONTHOST_USES_FONTMGR" ] 234 defines += [ "SK_FONTHOST_USES_FONTMGR" ]
235 235
236 cflags = [ 236 cflags = [
237 # TODO(brettw) comment what these are. 237 "/wd4244", # conversion from 'type1( __int64)' to 'type2 (unsigned int)'
238 "/wd4244", 238 "/wd4267", # conversion from 'size_t' (64 bit) to 'type'(32 bit).
239 "/wd4267", 239 "/wd4341", # signed value is out of range for enum constant.
240 "/wd4341", 240 "/wd4345", # Object is default-initialized if initialization is omitted.
241 "/wd4345", 241 "/wd4390", # ';'empty statement found in looping;is it what was intended?
242 "/wd4390", 242 "/wd4554", # 'operator' : check operator precedence for possible error
243 "/wd4554", 243 "/wd4748", # compiler will disable optimizations if a function has inline
244 "/wd4748", 244 # assembly code contains flow control(jmp or jcc) statements.
245 "/wd4800", 245 "/wd4800", # forcing value to bool 'true/false'(assigning int to bool).
246 ] 246 ]
247 } 247 }
248 } 248 }
249 249
250 component("skia") { 250 component("skia") {
251 sources = [ 251 sources = [
252 # Chrome sources. 252 # Chrome sources.
253 "config/SkUserConfig.h", 253 "config/SkUserConfig.h",
254 "ext/analysis_canvas.cc", 254 "ext/analysis_canvas.cc",
255 "ext/analysis_canvas.h", 255 "ext/analysis_canvas.h",
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
704 ":skia_config", 704 ":skia_config",
705 "//build/config/compiler:no_chromium_code" 705 "//build/config/compiler:no_chromium_code"
706 ] 706 ]
707 707
708 deps = [ 708 deps = [
709 "//base", 709 "//base",
710 ] 710 ]
711 711
712 visibility = [ ":skia" ] 712 visibility = [ ":skia" ]
713 } 713 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698