Added the detailed description for MSVC warning in BUILD.gn

skia/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 if (cpu_arch == "arm") {
   import("//build/config/arm.gni")
 }
 
@@ skipping 216 matching lines @@
 
   if (is_win) {
     include_dirs = [
       "//third_party/skia/include/utils/win",
       "//third_party/skia/src/utils/win",
     ]
 
     defines += [ "SK_FONTHOST_USES_FONTMGR" ]
 
     cflags = [
       # TODO(brettw) comment what these are.

[brettw, 2014/09/19 20:46:21]

Remove todo.

-      "/wd4244",
-      "/wd4267",
-      "/wd4341",
-      "/wd4345",
-      "/wd4390",
-      "/wd4554",
-      "/wd4748",
-      "/wd4800",
+      "/wd4244", # To suppress the warning conversion' conversion from 'type1( __int64)' to 'type2 (unsigned int)', possible loss of data

[brettw, 2014/09/19 20:46:22]

You can remove "to suppress the warning" on every line. If any of them are still
>80 cols, can you shorten them until they fit? The descriptions don't need to be
super detailed.

+      "/wd4267", # To suppress the warning  conversion from 'size_t' (64 bit) to 'type'(32 bit), possible loss of data
+      "/wd4341", # To suppress the warning  signed value is out of range for enum constant
+      "/wd4345", # To suppress the warning  If the new-initializer is omitted (with empty like '()'), then object is default-initialized.
+      "/wd4390", # To suppress the warning  ';' : empty controlled statement found in looping; is this what was intended?
+      "/wd4554", # To suppress the warning  'operator' : check operator precedence for possible error
+      "/wd4748", # To suppress the warning  The compiler will disable optimizations if a function has inline assembly
+                 # code containing flow of control (jmp or jcc, for example) statements.
+      "/wd4800", # To suppress the warning  forcing value to bool 'true' or 'false'
+                 # (assigning int variables to bool variables where the int variable contains only values true and false)
     ]
   }
 }
 
 component("skia") {
   sources = [
     # Chrome sources.
     "config/SkUserConfig.h",
     "ext/analysis_canvas.cc",
     "ext/analysis_canvas.h",
@@ skipping 448 matching lines @@
     ":skia_config",
     "//build/config/compiler:no_chromium_code"
   ]
 
   deps = [
     "//base",
   ]
 
   visibility = [ ":skia" ]
 }