Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 588193003: Defer maximize mode bounds updates until after exiting overview. (Closed)

Created:
6 years, 3 months ago by flackr
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Defer maximize mode bounds updates until after exiting overview. When we enter overview the shelf is revealed which causes a workspace bounds change. Normally the maximize mode window manager would update all active windows to have the new bounds but this effectively undoes the transformation applied to the window to show it in overview. As such, we defer updating the bounds until we exit overview mode. BUG=401664 TEST=WindowSelectorTest.FullscreenWindowMaximizeMode, WindowAnimationsTest.CrossFadeToBoundsFromTransform TEST=Repro steps in http://crbug.com/401664 Committed: https://crrev.com/d954b810db46c2590d7fc0715fcb8e66f961382d Cr-Commit-Position: refs/heads/master@{#297455}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add test WindowAnimationsTest.CrossFadeToBoundsFromTransform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -8 lines) Patch
M ash/wm/maximize_mode/maximize_mode_window_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 4 chunks +14 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +41 lines, -0 lines 0 comments Download
M ash/wm/window_animations.cc View 3 chunks +15 lines, -7 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
M ash/wm/window_state.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
flackr
Stefan, can you have a look? MaximizeModeWindowState was undoing the transform in overview mode in ...
6 years, 3 months ago (2014-09-22 13:36:42 UTC) #2
Mr4D (OOO till 08-26)
I do not really like the new flag, but I can see that for Overview ...
6 years, 3 months ago (2014-09-23 22:27:15 UTC) #3
flackr
https://codereview.chromium.org/588193003/diff/1/ash/wm/maximize_mode/maximize_mode_window_state.cc File ash/wm/maximize_mode/maximize_mode_window_state.cc (right): https://codereview.chromium.org/588193003/diff/1/ash/wm/maximize_mode/maximize_mode_window_state.cc#newcode294 ash/wm/maximize_mode/maximize_mode_window_state.cc:294: if (defer_bounds_updates_) On 2014/09/23 22:27:14, Mr4D wrote: > Just ...
6 years, 2 months ago (2014-09-30 16:42:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588193003/20001
6 years, 2 months ago (2014-09-30 17:38:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 744a3f7bf631e0e336055cb92f4b1cc28b6bf7c0
6 years, 2 months ago (2014-09-30 18:19:09 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:20:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d954b810db46c2590d7fc0715fcb8e66f961382d
Cr-Commit-Position: refs/heads/master@{#297455}

Powered by Google App Engine
This is Rietveld 408576698