Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 587913002: app_shell: Remove some NOTIMPLEMENTED from ShellNativeAppWindow (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

app_shell: Remove some NOTIMPLEMENTED from ShellNativeAppWindow For these functions the default no-op behavior is fine, so remove the calls to NOTIMPLEMENTED to reduce log spam. BUG=none TEST=none TBR=yoz@chromium.org for changing a comment in extensions/ Committed: https://crrev.com/14f0c3d1df8086e18097e1cf1c648d5b6fc9890c Cr-Commit-Position: refs/heads/master@{#295836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -27 lines) Patch
M extensions/browser/app_window/app_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_app_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_app_window_client.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_native_app_window.cc View 10 chunks +36 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
derat, PTAL
6 years, 3 months ago (2014-09-19 21:38:24 UTC) #2
Daniel Erat
lgtm
6 years, 3 months ago (2014-09-19 21:43:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587913002/1
6 years, 3 months ago (2014-09-19 22:07:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3281faddb1fd6c3b0c150814612d29a6e1971e7a
6 years, 3 months ago (2014-09-20 01:00:21 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 01:00:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14f0c3d1df8086e18097e1cf1c648d5b6fc9890c
Cr-Commit-Position: refs/heads/master@{#295836}

Powered by Google App Engine
This is Rietveld 408576698