Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: extensions/shell/browser/shell_app_delegate.cc

Issue 587913002: app_shell: Remove some NOTIMPLEMENTED from ShellNativeAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/shell/browser/shell_app_delegate.h" 5 #include "extensions/shell/browser/shell_app_delegate.h"
6 6
7 #include "extensions/common/constants.h" 7 #include "extensions/common/constants.h"
8 #include "extensions/shell/browser/media_capture_util.h" 8 #include "extensions/shell/browser/media_capture_util.h"
9 9
10 namespace extensions { 10 namespace extensions {
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 bool blocked) { 85 bool blocked) {
86 NOTIMPLEMENTED(); 86 NOTIMPLEMENTED();
87 } 87 }
88 88
89 bool ShellAppDelegate::IsWebContentsVisible( 89 bool ShellAppDelegate::IsWebContentsVisible(
90 content::WebContents* web_contents) { 90 content::WebContents* web_contents) {
91 return true; 91 return true;
92 } 92 }
93 93
94 void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) { 94 void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) {
95 // TODO(jamescook): Should app_shell continue to close the app window
96 // manually or should it use a browser termination callback like Chrome?
95 NOTIMPLEMENTED(); 97 NOTIMPLEMENTED();
96 } 98 }
97 99
98 } // namespace extensions 100 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/app_window/app_delegate.h ('k') | extensions/shell/browser/shell_app_window_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698