extensions/shell/browser/shell_app_delegate.cc - Issue 587913002: app_shell: Remove some NOTIMPLEMENTED from ShellNativeAppWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_app_delegate.cc

Issue 587913002: app_shell: Remove some NOTIMPLEMENTED from ShellNativeAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/browser/shell_app_delegate.cc

diff --git a/extensions/shell/browser/shell_app_delegate.cc b/extensions/shell/browser/shell_app_delegate.cc

index 483da67032d52a3c581f5b5c294284573962eaed..be70ec4f3f6242a2d5e86695338579b68e433d62 100644

--- a/extensions/shell/browser/shell_app_delegate.cc

+++ b/extensions/shell/browser/shell_app_delegate.cc

@@ -92,6 +92,8 @@ bool ShellAppDelegate::IsWebContentsVisible(

}

void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) {

+ // TODO(jamescook): Should app_shell continue to close the app window

+ // manually or should it use a browser termination callback like Chrome?

NOTIMPLEMENTED();

}

« no previous file with comments | « extensions/browser/app_window/app_delegate.h ('k') | extensions/shell/browser/shell_app_window_client.cc » ('j') | no next file with comments »