Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: extensions/shell/browser/shell_app_window_client.cc

Issue 587913002: app_shell: Remove some NOTIMPLEMENTED from ShellNativeAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/shell/browser/shell_app_window_client.h" 5 #include "extensions/shell/browser/shell_app_window_client.h"
6 6
7 #include <vector>
8
7 #include "extensions/browser/app_window/app_window.h" 9 #include "extensions/browser/app_window/app_window.h"
8 #include "extensions/shell/browser/desktop_controller.h" 10 #include "extensions/shell/browser/desktop_controller.h"
9 #include "extensions/shell/browser/shell_native_app_window.h" 11 #include "extensions/shell/browser/shell_native_app_window.h"
10 12
11 namespace extensions { 13 namespace extensions {
12 14
13 ShellAppWindowClient::ShellAppWindowClient() { 15 ShellAppWindowClient::ShellAppWindowClient() {
14 } 16 }
15 17
16 ShellAppWindowClient::~ShellAppWindowClient() { 18 ShellAppWindowClient::~ShellAppWindowClient() {
(...skipping 15 matching lines...) Expand all
32 AppWindow* window, 34 AppWindow* window,
33 const AppWindow::CreateParams& params) { 35 const AppWindow::CreateParams& params) {
34 ShellNativeAppWindow* native_app_window = 36 ShellNativeAppWindow* native_app_window =
35 new ShellNativeAppWindow(window, params); 37 new ShellNativeAppWindow(window, params);
36 DesktopController::instance()->AddAppWindow( 38 DesktopController::instance()->AddAppWindow(
37 native_app_window->GetNativeWindow()); 39 native_app_window->GetNativeWindow());
38 return native_app_window; 40 return native_app_window;
39 } 41 }
40 42
41 void ShellAppWindowClient::IncrementKeepAliveCount() { 43 void ShellAppWindowClient::IncrementKeepAliveCount() {
42 NOTIMPLEMENTED(); 44 // app_shell runs until the system powers off, so it doesn't need to track
45 // open apps or windows to keep itself alive.
43 } 46 }
44 47
45 void ShellAppWindowClient::DecrementKeepAliveCount() { 48 void ShellAppWindowClient::DecrementKeepAliveCount() {
46 NOTIMPLEMENTED(); 49 // See IncrementKeepAliveCount().
47 } 50 }
48 51
49 void ShellAppWindowClient::OpenDevToolsWindow( 52 void ShellAppWindowClient::OpenDevToolsWindow(
50 content::WebContents* web_contents, 53 content::WebContents* web_contents,
51 const base::Closure& callback) { 54 const base::Closure& callback) {
52 NOTIMPLEMENTED(); 55 NOTIMPLEMENTED();
53 } 56 }
54 57
55 bool ShellAppWindowClient::IsCurrentChannelOlderThanDev() { 58 bool ShellAppWindowClient::IsCurrentChannelOlderThanDev() {
56 return false; 59 return false;
57 } 60 }
58 61
59 } // namespace extensions 62 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/shell/browser/shell_app_delegate.cc ('k') | extensions/shell/browser/shell_native_app_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698