Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 587653002: IDL: Conversion to Dictionary is trivial (can't fail) (Closed)

Created:
6 years, 3 months ago by Jens Widell
Modified:
6 years, 3 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Conversion to Dictionary is trivial (can't fail) Conversion from v8::Value to blink::Dictionary simply stores a reference to the v8::Value in the blink::Dictionary object, so can't throw an exception. Adjust v8_conversion_is_trivial() accordingly, to avoid use of TONATIVE_VOID(_INTERNAL) and thus declaration of unnecessary v8::TryCatch locals. BUG=413257 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182331

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -20 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jens Widell
PTAL
6 years, 3 months ago (2014-09-19 12:02:02 UTC) #2
bashi
LGTM
6 years, 3 months ago (2014-09-19 12:23:14 UTC) #3
haraken
LGTM2
6 years, 3 months ago (2014-09-19 12:33:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/587653002/2
6 years, 3 months ago (2014-09-19 12:52:41 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 14:36:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:2) as 182331

Powered by Google App Engine
This is Rietveld 408576698