Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 587653002: IDL: Conversion to Dictionary is trivial (can't fail) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp
index b4dcb721c3e3086d6142dfba7789133a65dc4bb8..4b52e786157af835d06ae75ab91311f16eb02b15 100644
--- a/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -6591,7 +6591,7 @@ static void promiseMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
v8SetReturnValue(info, exceptionState.reject(ScriptState::current(info.GetIsolate())).v8Value());
return;
}
- TONATIVE_VOID_PROMISE_INTERNAL(arg2, Dictionary(info[1], info.GetIsolate()), info);
+ arg2 = Dictionary(info[1], info.GetIsolate());
TOSTRING_VOID_PROMISE_INTERNAL(arg3, info[2], info);
TONATIVE_VOID_PROMISE_INTERNAL(variadic, toImplArguments<String>(info, 3), info);
}
@@ -6614,13 +6614,11 @@ static void promiseMethodWithoutExceptionStateMethod(const v8::FunctionCallbackI
TestObject* impl = V8TestObject::toImpl(info.Holder());
Dictionary arg1;
{
- v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
if (!isUndefinedOrNull(info[0]) && !info[0]->IsObject()) {
v8SetReturnValue(info, ScriptPromise::rejectRaw(info.GetIsolate(), V8ThrowException::createTypeError(ExceptionMessages::failedToExecute("promiseMethodWithoutExceptionState", "TestObject", "parameter 1 ('arg1') is not an object."), info.GetIsolate())));
return;
}
- TONATIVE_VOID_PROMISE_INTERNAL(arg1, Dictionary(info[0], info.GetIsolate()), info);
+ arg1 = Dictionary(info[0], info.GetIsolate());
}
v8SetReturnValue(info, impl->promiseMethodWithoutExceptionState(arg1).v8Value());
}
@@ -6667,13 +6665,11 @@ static void voidMethodDictionaryArgMethod(const v8::FunctionCallbackInfo<v8::Val
TestObject* impl = V8TestObject::toImpl(info.Holder());
Dictionary dictionaryArg;
{
- v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
if (!isUndefinedOrNull(info[0]) && !info[0]->IsObject()) {
V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("voidMethodDictionaryArg", "TestObject", "parameter 1 ('dictionaryArg') is not an object."), info.GetIsolate());
return;
}
- TONATIVE_VOID_INTERNAL(dictionaryArg, Dictionary(info[0], info.GetIsolate()));
+ dictionaryArg = Dictionary(info[0], info.GetIsolate());
}
impl->voidMethodDictionaryArg(dictionaryArg);
}
@@ -7145,13 +7141,11 @@ static void voidMethodOptionalDictionaryArgMethod(const v8::FunctionCallbackInfo
TestObject* impl = V8TestObject::toImpl(info.Holder());
Dictionary optionalDictionaryArg;
{
- v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
if (!isUndefinedOrNull(info[0]) && !info[0]->IsObject()) {
V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("voidMethodOptionalDictionaryArg", "TestObject", "parameter 1 ('optionalDictionaryArg') is not an object."), info.GetIsolate());
return;
}
- TONATIVE_VOID_INTERNAL(optionalDictionaryArg, Dictionary(info[0], info.GetIsolate()));
+ optionalDictionaryArg = Dictionary(info[0], info.GetIsolate());
}
impl->voidMethodOptionalDictionaryArg(optionalDictionaryArg);
}
« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698