Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp - Issue 587653002: IDL: Conversion to Dictionary is trivial (can't fail)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

Issue 587653002: IDL: Conversion to Dictionary is trivial (can't fail) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

index afdcf03042525d68d822521b61082e21c713a76d..ec5269098df7e573d0d68c9fca4b945a9c44b989 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

@@ -242,7 +242,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

v8::Local<v8::Value> initializedByEventConstructorReadonlyAnyAttribute;

TestInterfaceEventConstructorInit eventInit;

if (info.Length() >= 2) {

- TONATIVE_VOID(Dictionary, options, Dictionary(info[1], info.GetIsolate()));

+ Dictionary options(info[1], info.GetIsolate());

if (!initializeTestInterfaceEventConstructor(eventInit, options, exceptionState, info)) {

exceptionState.throwIfNeeded();

return;