Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 586933002: Re-Revert "[WebModals] New API for browser-scoped popup management." (Closed)

Created:
6 years, 3 months ago by Greg Billock
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, dkrahn+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Re-Revert "[WebModals] New API for browser-scoped popup management." This reverts commit 010152f1c2f749b629ad20d90df33d13355b5797. Conflicts: apps/app_window.cc chrome/browser/chromeos/attestation/platform_verification_dialog.cc chrome/browser/ui/views/desktop_media_picker_views.cc chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc Second try. See https://codereview.chromium.org/574903002/ BUG=404755 Committed: https://chromium.googlesource.com/chromium/src/+/6de1e5a430a932f866c4eaa917f8c7aa052579d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -478 lines) Patch
M apps/app_window.h View 2 chunks +0 lines, -5 lines 0 comments Download
M apps/app_window.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_dialog.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc View 2 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_view_host.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_view_host.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser.cc View 5 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 5 chunks +8 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 3 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 3 chunks +15 lines, -5 lines 0 comments Download
M components/web_modal.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M components/web_modal/native_web_contents_modal_dialog.h View 2 chunks +0 lines, -10 lines 0 comments Download
D components/web_modal/popup_manager.h View 1 chunk +0 lines, -83 lines 0 comments Download
D components/web_modal/popup_manager.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D components/web_modal/single_popup_manager.h View 1 chunk +0 lines, -96 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Greg Billock
6 years, 3 months ago (2014-09-19 23:50:53 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 6de1e5a (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698