Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm

Issue 586933002: Re-Revert "[WebModals] New API for browser-scoped popup management." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2125
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/utf_string_conversions.h" 5 #include "base/strings/utf_string_conversions.h"
6 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h" 6 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h"
7 7
8 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock. h" 8 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock. h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h" 10 #include "chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h"
11 #include "chrome/browser/ui/tabs/tab_strip_model.h" 11 #include "chrome/browser/ui/tabs/tab_strip_model.h"
12 #include "chrome/test/base/in_process_browser_test.h" 12 #include "chrome/test/base/in_process_browser_test.h"
13 #include "components/web_modal/popup_manager.h" 13 #include "components/web_modal/web_contents_modal_dialog_manager.h"
14 #include "content/public/test/test_utils.h" 14 #include "content/public/test/test_utils.h"
15 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
16 16
17 using ::testing::_; 17 using ::testing::_;
18 using ::testing::AnyNumber; 18 using ::testing::AnyNumber;
19 using ::testing::NiceMock; 19 using ::testing::NiceMock;
20 using ::testing::Return; 20 using ::testing::Return;
21 using ::testing::ReturnRef; 21 using ::testing::ReturnRef;
22 using web_modal::WebContentsModalDialogManager;
22 23
23 class MediaGalleriesDialogBrowserTest : public InProcessBrowserTest { 24 class MediaGalleriesDialogBrowserTest : public InProcessBrowserTest {
24 }; 25 };
25 26
26 // Verify that programatically closing the constrained window correctly closes 27 // Verify that programatically closing the constrained window correctly closes
27 // the sheet. 28 // the sheet.
28 IN_PROC_BROWSER_TEST_F(MediaGalleriesDialogBrowserTest, Close) { 29 IN_PROC_BROWSER_TEST_F(MediaGalleriesDialogBrowserTest, Close) {
29 NiceMock<MediaGalleriesDialogControllerMock> controller; 30 NiceMock<MediaGalleriesDialogControllerMock> controller;
30 31
31 content::WebContents* web_contents = 32 content::WebContents* web_contents =
32 browser()->tab_strip_model()->GetActiveWebContents(); 33 browser()->tab_strip_model()->GetActiveWebContents();
33 EXPECT_CALL(controller, WebContents()). 34 EXPECT_CALL(controller, WebContents()).
34 WillRepeatedly(Return(web_contents)); 35 WillRepeatedly(Return(web_contents));
35 std::vector<base::string16> headers; 36 std::vector<base::string16> headers;
36 headers.push_back(base::string16()); // The first section has no header. 37 headers.push_back(base::string16()); // The first section has no header.
37 headers.push_back(base::ASCIIToUTF16("header2")); 38 headers.push_back(base::ASCIIToUTF16("header2"));
38 ON_CALL(controller, GetSectionHeaders()). 39 ON_CALL(controller, GetSectionHeaders()).
39 WillByDefault(Return(headers)); 40 WillByDefault(Return(headers));
40 EXPECT_CALL(controller, GetAuxiliaryButtonText()). 41 EXPECT_CALL(controller, GetAuxiliaryButtonText()).
41 WillRepeatedly(Return(base::ASCIIToUTF16("button"))); 42 WillRepeatedly(Return(base::ASCIIToUTF16("button")));
42 EXPECT_CALL(controller, GetSectionEntries(_)). 43 EXPECT_CALL(controller, GetSectionEntries(_)).
43 Times(AnyNumber()); 44 Times(AnyNumber());
44 45
45 scoped_ptr<MediaGalleriesDialogCocoa> dialog( 46 scoped_ptr<MediaGalleriesDialogCocoa> dialog(
46 static_cast<MediaGalleriesDialogCocoa*>( 47 static_cast<MediaGalleriesDialogCocoa*>(
47 MediaGalleriesDialog::Create(&controller))); 48 MediaGalleriesDialog::Create(&controller)));
48 base::scoped_nsobject<NSWindow> window([[dialog->alert_ window] retain]); 49 base::scoped_nsobject<NSWindow> window([[dialog->alert_ window] retain]);
49 EXPECT_TRUE([window isVisible]); 50 EXPECT_TRUE([window isVisible]);
50 51
51 web_modal::PopupManager* popup_manager = 52 WebContentsModalDialogManager* web_contents_modal_dialog_manager =
52 web_modal::PopupManager::FromWebContents(web_contents); 53 WebContentsModalDialogManager::FromWebContents(web_contents);
53 popup_manager->CloseAllDialogsForTesting(web_contents); 54 WebContentsModalDialogManager::TestApi test_api(
55 web_contents_modal_dialog_manager);
56 test_api.CloseAllDialogs();
54 EXPECT_FALSE([window isVisible]); 57 EXPECT_FALSE([window isVisible]);
55 } 58 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm ('k') | chrome/browser/ui/tabs/tab_strip_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698