Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3595)

Unified Diff: chrome/browser/chromeos/login/ui/webui_login_view.h

Issue 586933002: Re-Revert "[WebModals] New API for browser-scoped popup management." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2125
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/webui_login_view.h
diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.h b/chrome/browser/chromeos/login/ui/webui_login_view.h
index 82713dbe591d352aaa33eed9f542c15404787812..1d65dba21fb9b67f351d514ff3549e5c1577f6cd 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_view.h
+++ b/chrome/browser/chromeos/login/ui/webui_login_view.h
@@ -12,7 +12,6 @@
#include "base/observer_list.h"
#include "chrome/browser/extensions/signin/scoped_gaia_auth_extension.h"
#include "chrome/browser/ui/chrome_web_modal_dialog_manager_delegate.h"
-#include "components/web_modal/popup_manager.h"
#include "components/web_modal/web_contents_modal_dialog_host.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -194,11 +193,6 @@ class WebUILoginView : public views::View,
ObserverList<web_modal::ModalDialogHostObserver> observer_list_;
ObserverList<FrameObserver> frame_observer_list_;
- // Manage popups appearing over the login window.
- // TODO(gbillock): See if we can get rid of this. Perhaps in favor of
- // in-content styled popups or something? There oughtta be a way...
- scoped_ptr<web_modal::PopupManager> popup_manager_;
-
DISALLOW_COPY_AND_ASSIGN(WebUILoginView);
};
« no previous file with comments | « chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc ('k') | chrome/browser/chromeos/login/ui/webui_login_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698