Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Side by Side Diff: chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc

Issue 586933002: Re-Revert "[WebModals] New API for browser-scoped popup management." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2125
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h" 5 #include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/ui/views/constrained_window_views.h" 8 #include "chrome/browser/ui/views/constrained_window_views.h"
9 #include "chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h" 9 #include "chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h"
10 #include "chrome/grit/generated_resources.h" 10 #include "chrome/grit/generated_resources.h"
11 #include "chrome/grit/locale_settings.h" 11 #include "chrome/grit/locale_settings.h"
12 #include "components/web_modal/popup_manager.h" 12 #include "components/web_modal/web_contents_modal_dialog_manager.h"
13 #include "content/public/browser/web_contents.h" 13 #include "content/public/browser/web_contents.h"
14 #include "ui/base/l10n/l10n_util.h" 14 #include "ui/base/l10n/l10n_util.h"
15 #include "ui/native_theme/native_theme.h" 15 #include "ui/native_theme/native_theme.h"
16 #include "ui/views/border.h" 16 #include "ui/views/border.h"
17 #include "ui/views/controls/button/checkbox.h" 17 #include "ui/views/controls/button/checkbox.h"
18 #include "ui/views/controls/button/image_button.h" 18 #include "ui/views/controls/button/image_button.h"
19 #include "ui/views/controls/button/label_button.h" 19 #include "ui/views/controls/button/label_button.h"
20 #include "ui/views/controls/label.h" 20 #include "ui/views/controls/label.h"
21 #include "ui/views/controls/menu/menu_runner.h" 21 #include "ui/views/controls/menu/menu_runner.h"
22 #include "ui/views/controls/scroll_view.h" 22 #include "ui/views/controls/scroll_view.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 } 72 }
73 73
74 MediaGalleriesDialogViews::~MediaGalleriesDialogViews() { 74 MediaGalleriesDialogViews::~MediaGalleriesDialogViews() {
75 if (!ControllerHasWebContents()) 75 if (!ControllerHasWebContents())
76 delete contents_; 76 delete contents_;
77 } 77 }
78 78
79 void MediaGalleriesDialogViews::AcceptDialogForTesting() { 79 void MediaGalleriesDialogViews::AcceptDialogForTesting() {
80 accepted_ = true; 80 accepted_ = true;
81 81
82 web_modal::PopupManager* popup_manager = 82 web_modal::WebContentsModalDialogManager* web_contents_modal_dialog_manager =
83 web_modal::PopupManager::FromWebContents(controller_->WebContents()); 83 web_modal::WebContentsModalDialogManager::FromWebContents(
84 DCHECK(popup_manager); 84 controller_->WebContents());
85 popup_manager->CloseAllDialogsForTesting(controller_->WebContents()); 85 DCHECK(web_contents_modal_dialog_manager);
86 web_modal::WebContentsModalDialogManager::TestApi(
87 web_contents_modal_dialog_manager).CloseAllDialogs();
86 } 88 }
87 89
88 void MediaGalleriesDialogViews::InitChildViews() { 90 void MediaGalleriesDialogViews::InitChildViews() {
89 // Outer dialog layout. 91 // Outer dialog layout.
90 contents_->RemoveAllChildViews(true); 92 contents_->RemoveAllChildViews(true);
91 checkbox_map_.clear(); 93 checkbox_map_.clear();
92 94
93 int dialog_content_width = views::Widget::GetLocalizedContentsWidth( 95 int dialog_content_width = views::Widget::GetLocalizedContentsWidth(
94 IDS_MEDIA_GALLERIES_DIALOG_CONTENT_WIDTH_CHARS); 96 IDS_MEDIA_GALLERIES_DIALOG_CONTENT_WIDTH_CHARS);
95 views::GridLayout* layout = views::GridLayout::CreatePanel(contents_); 97 views::GridLayout* layout = views::GridLayout::CreatePanel(contents_);
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 return controller_->WebContents() != NULL; 327 return controller_->WebContents() != NULL;
326 } 328 }
327 329
328 // MediaGalleriesDialogViewsController ----------------------------------------- 330 // MediaGalleriesDialogViewsController -----------------------------------------
329 331
330 // static 332 // static
331 MediaGalleriesDialog* MediaGalleriesDialog::Create( 333 MediaGalleriesDialog* MediaGalleriesDialog::Create(
332 MediaGalleriesDialogController* controller) { 334 MediaGalleriesDialogController* controller) {
333 return new MediaGalleriesDialogViews(controller); 335 return new MediaGalleriesDialogViews(controller);
334 } 336 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698