Change GrGLProgramDesc header to have DoPathRendering flag instead of RequiresVertexShader

Change GrGLProgramDesc header to have DoPathRendering flag instead of RequiresVertexShader

Also update GLProgramTests to fix bug where it would incorrectly try to PathRendering when we did
not want to.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ae444965c43ad16575730ce8e3abdcaded296d94

[egdaniel, 2014-09-19 17:18:44]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@chromium.org

[egdaniel, 2014-09-19 17:18:45]

https://codereview.chromium.org/586793002/diff/1/src/gpu/gl/GrGLProgramDesc.cpp
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/586793002/diff/1/src/gpu/gl/GrGLProgramDesc.c...
src/gpu/gl/GrGLProgramDesc.cpp:139: header->fDoPathRendering =
gpu->caps()->pathRenderingSupport() &&
in a future CL I may move this logic into ODS.

[bsalomon, 2014-09-19 17:29:49]

https://codereview.chromium.org/586793002/diff/1/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/586793002/diff/1/src/gpu/gl/GrGLProgram.cpp#n...
src/gpu/gl/GrGLProgram.cpp:31: if (desc.getHeader().fDoPathRendering) {
I think this should have a different name since we may do path rendering and not
set this (on NVPR 1.3+). 

Can we name it fUseVS or fFragmentOnly or something like that?

[egdaniel, 2014-09-19 17:44:05]

https://codereview.chromium.org/586793002/diff/1/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/586793002/diff/1/src/gpu/gl/GrGLProgram.cpp#n...
src/gpu/gl/GrGLProgram.cpp:31: if (desc.getHeader().fDoPathRendering) {
changed to fUseFragShaderOnly

On 2014/09/19 17:29:49, bsalomon wrote:
> I think this should have a different name since we may do path rendering and
not
> set this (on NVPR 1.3+). 
> 
> Can we name it fUseVS or fFragmentOnly or something like that?

[egdaniel, 2014-09-22 15:23:59]

ping

[egdaniel, 2014-09-22 16:45:16]

updated

[bsalomon, 2014-09-22 18:03:00]

lgtm

[egdaniel, 2014-09-22 18:51:08]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-09-22 18:52:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586793002/40001

[egdaniel, 2014-09-22 19:17:19]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-09-22 19:18:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586793002/60001

[commit-bot: I haz the power, 2014-09-22 19:29:56]

Committed patchset #4 (id:60001) as ae444965c43ad16575730ce8e3abdcaded296d94