Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2719)

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 584383002: Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_delegate.h
diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
index 0f630f3b9006ec76b1ca3c0103ddd24e01f208f7..25aa15a5004e770e0b35d45c39dac67a4a9c5930 100644
--- a/content/public/browser/web_contents_delegate.h
+++ b/content/public/browser/web_contents_delegate.h
@@ -438,6 +438,7 @@ class CONTENT_EXPORT WebContentsDelegate {
// request is denied, a call should be made to |callback| with an empty list
// of devices. |request| has the details of the request (e.g. which of audio
// and/or video devices are requested, and lists of available devices).
+ // Delegates that expect this to be ever called, must implement the function.
tommi (sloooow) - chröme 2014/09/20 14:25:38 I'd prefer pure virtual here and below.
Henrik Grunell 2014/09/22 08:49:52 Done.
virtual void RequestMediaAccessPermission(
WebContents* web_contents,
const MediaStreamRequest& request,
@@ -446,6 +447,7 @@ class CONTENT_EXPORT WebContentsDelegate {
// Checks if we have permission to access the microphone or camera. Note that
// this does not query the user. |type| must be MEDIA_DEVICE_AUDIO_CAPTURE
// or MEDIA_DEVICE_VIDEO_CAPTURE.
+ // Delegates that expect this to be ever called, must implement the function.
virtual bool CheckMediaAccessPermission(WebContents* web_contents,
const GURL& security_origin,
MediaStreamType type);

Powered by Google App Engine
This is Rietveld 408576698