Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Unified Diff: content/public/browser/web_contents_delegate.cc

Issue 584383002: Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_delegate.cc
diff --git a/content/public/browser/web_contents_delegate.cc b/content/public/browser/web_contents_delegate.cc
index 72cabb4b62f5bff36c8bd7276506c702f76bf238..6c504ad8839c08dcc4267a3c36ae718be94e974f 100644
--- a/content/public/browser/web_contents_delegate.cc
+++ b/content/public/browser/web_contents_delegate.cc
@@ -164,6 +164,7 @@ void WebContentsDelegate::RequestMediaAccessPermission(
WebContents* web_contents,
const MediaStreamRequest& request,
const MediaResponseCallback& callback) {
+ NOTREACHED();
callback.Run(MediaStreamDevices(),
MEDIA_DEVICE_INVALID_STATE,
scoped_ptr<MediaStreamUI>());
@@ -173,8 +174,7 @@ bool WebContentsDelegate::CheckMediaAccessPermission(
WebContents* web_contents,
const GURL& security_origin,
MediaStreamType type) {
- DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||
- type == MEDIA_DEVICE_VIDEO_CAPTURE);
+ NOTREACHED();
return false;
}

Powered by Google App Engine
This is Rietveld 408576698