Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations

content/browser/frame_host/render_frame_host_delegate.cc

Index: content/browser/frame_host/render_frame_host_delegate.cc
diff --git a/content/browser/frame_host/render_frame_host_delegate.cc b/content/browser/frame_host/render_frame_host_delegate.cc
index b96f2b55cd5553d68da2d09ef931444dc92bad71..58ef20b311c23abf95f90b672be5094dd2df2356 100644
--- a/content/browser/frame_host/render_frame_host_delegate.cc
+++ b/content/browser/frame_host/render_frame_host_delegate.cc
@@ -39,6 +39,7 @@ WebContents* RenderFrameHostDelegate::GetAsWebContents() {
 void RenderFrameHostDelegate::RequestMediaAccessPermission(
     const MediaStreamRequest& request,
     const MediaResponseCallback& callback) {
+  NOTREACHED();

[tommi (sloooow) - chröme, 2014/09/20 14:25:38]

I'm not sure about this since there is an implementation here already.

If these methods are not expected to be called, can we skip implementing them
altogether and force subclasses to make this decision (implement vs
NOTREACHED())?

[Henrik Grunell, 2014/09/22 08:49:52]

Yeah, Per and I discussed this before. I had that standpoint at first, then we
kind of came to the conclusion to do it here. Changed.

   callback.Run(MediaStreamDevices(),
                MEDIA_DEVICE_INVALID_STATE,
                scoped_ptr<MediaStreamUI>());
@@ -47,8 +48,7 @@ void RenderFrameHostDelegate::RequestMediaAccessPermission(
 bool RenderFrameHostDelegate::CheckMediaAccessPermission(
     const GURL& security_origin,
     MediaStreamType type) {
-  DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||
-         type == MEDIA_DEVICE_VIDEO_CAPTURE);
+  NOTREACHED();
   return false;
 }