Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 
 #include <set>
 #include <string>
 
@@ skipping 420 matching lines @@
                                   bool last_unlocked_by_target) {}
 
   // Notification that the page has lost the mouse lock.
   virtual void LostMouseLock() {}
 
   // Asks permission to use the camera and/or microphone. If permission is
   // granted, a call should be made to |callback| with the devices. If the
   // request is denied, a call should be made to |callback| with an empty list
   // of devices. |request| has the details of the request (e.g. which of audio
   // and/or video devices are requested, and lists of available devices).
+  // Delegates that expect this to be ever called, must implement the function.

[tommi (sloooow) - chröme, 2014/09/20 14:25:38]

I'd prefer pure virtual here and below.

[Henrik Grunell, 2014/09/22 08:49:52]

Done.

   virtual void RequestMediaAccessPermission(
       WebContents* web_contents,
       const MediaStreamRequest& request,
       const MediaResponseCallback& callback);
 
   // Checks if we have permission to access the microphone or camera. Note that
   // this does not query the user. |type| must be MEDIA_DEVICE_AUDIO_CAPTURE
   // or MEDIA_DEVICE_VIDEO_CAPTURE.
+  // Delegates that expect this to be ever called, must implement the function.
   virtual bool CheckMediaAccessPermission(WebContents* web_contents,
                                           const GURL& security_origin,
                                           MediaStreamType type);
 
   // Requests permission to access the PPAPI broker. The delegate should return
   // true and call the passed in |callback| with the result, or return false
   // to indicate that it does not support asking for permission.
   virtual bool RequestPpapiBrokerPermission(
       WebContents* web_contents,
       const GURL& url,
@@ skipping 38 matching lines @@
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_