Issue 583883003: [Password Generation] Change links in the bubble to point to the local manager

Issue 583883003: [Password Generation] Change links in the bubble to point to the local manager (Closed)

Created:
6 years, 3 months ago by Garrett Casto

Modified:
6 years, 3 months ago

Reviewers:
groby-ooo-7-16, Mike West

CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[Password Generation] Change links in the bubble to point to the local manager BUG=413846 Committed: https://crrev.com/fe87d97abc869fe811a05c92511ed1fa548817d8 Cr-Commit-Position: refs/heads/master@{#296482}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -45 lines)			Patch
M	chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller_unittest.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_bubble_model.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_bubble_model.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_ui_controller.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_ui_controller.cc	View	1 2	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (2 generated)

groby-ooo-7-16

AFAICT, it's merely a function rename on the Cocoa side - feel free to TBR ...

6 years, 3 months ago (2014-09-23 22:29:26 UTC) #3

Garrett Casto

On 2014/09/23 22:29:26, groby wrote: > AFAICT, it's merely a function rename on the Cocoa ...

6 years, 3 months ago (2014-09-23 22:31:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583883003/60001

6 years, 3 months ago (2014-09-24 18:23:22 UTC) #7

commit-bot: I haz the power

Committed patchset #4 (id:60001) as 7ae7e086bed0bfe5b42c255b786623f10dd2a29c

6 years, 3 months ago (2014-09-24 19:11:18 UTC) #8

commit-bot: I haz the power

6 years, 3 months ago (2014-09-24 19:11:55 UTC) #9

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/fe87d97abc869fe811a05c92511ed1fa548817d8
Cr-Commit-Position: refs/heads/master@{#296482}