chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm - Issue 583883003: [Password Generation] Change links in the bubble to point to the local manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm

Issue 583883003: [Password Generation] Change links in the bubble to point to the local manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm

index 9d45f5ad1bccf31bd73c90875f54acdd91dda9d3..b822f333bd83f0a26e20f45a6e9e3d36a47f5171 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm

@@ -41,7 +41,7 @@ using namespace password_manager::mac::ui;

- (BOOL)textView:(NSTextView*)textView

clickedOnLink:(id)link

atIndex:(NSUInteger)charIndex {

- model_->OnRemoteManageLinkClicked();

+ model_->OnManageLinkClicked();

[delegate_ viewShouldDismiss];

return YES;

}

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller_unittest.mm » ('j') | no next file with comments »