chrome/browser/ui/passwords/manage_passwords_bubble_model.cc - Issue 583883003: [Password Generation] Change links in the bubble to point to the local manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 583883003: [Password Generation] Change links in the bubble to point to the local manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

index 091d0b6b222dbde772d5499eef358e9dec504393..5cc29c5eac76fce39e3f246ae30cfc84a21c8bfa 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

@@ -167,16 +167,6 @@ void ManagePasswordsBubbleModel::OnManageLinkClicked() {

->NavigateToPasswordManagerSettingsPage();

}

-// TODO(gcasto): Is it worth having a new dismissal reason to distinguish

-// the two management cases? User intention is pretty similar between the two,

-// but the context in which they are shown is pretty different since one is

-// from an explict action and the other isn't.

-void ManagePasswordsBubbleModel::OnRemoteManageLinkClicked() {

- dismissal_reason_ = metrics_util::CLICKED_MANAGE;

- ManagePasswordsUIController::FromWebContents(web_contents())

- ->NavigateToAccountCentralManagementPage();

void ManagePasswordsBubbleModel::OnPasswordAction(

const autofill::PasswordForm& password_form,

PasswordAction action) {