chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 583883003: [Password Generation] Change links in the bubble to point to the local manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 583883003: [Password Generation] Change links in the bubble to point to the local manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.h ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index 0dc9467ceeedd655f718a917c6979e1a97e7c362..ffa8ffad86f52e0fbb02af45a8bc9baefb900048 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -167,18 +167,6 @@ void ManagePasswordsUIController::

#endif

}

-void ManagePasswordsUIController::NavigateToAccountCentralManagementPage() {

- // TODO(gcasto): FindBowserWithWebContents() doesn't exist on Android.

- // Need to determine how this should work there.

-#if !defined(OS_ANDROID)

- Browser* browser = chrome::FindBrowserWithWebContents(web_contents());

- content::OpenURLParams params(

- GURL(chrome::kAutoPasswordGenerationLearnMoreURL), content::Referrer(),

- NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK, false);

- browser->OpenURL(params);

-#endif

void ManagePasswordsUIController::SavePassword() {

DCHECK(PasswordPendingUserDecision());

SavePasswordInternal();