Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 583803002: fix toString calls on Type objects in smoke (Closed)

Created:
6 years, 3 months ago by jakemac
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add test for toString #

Patch Set 3 : update pubspec/changelog #

Patch Set 4 : remove == support #

Patch Set 5 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M pkg/smoke/CHANGELOG.md View 1 2 1 chunk +7 lines, -8 lines 0 comments Download
M pkg/smoke/lib/mirrors.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/smoke/lib/static.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M pkg/smoke/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/smoke/test/codegen/end_to_end_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/smoke/test/common.dart View 1 2 chunks +5 lines, -1 line 0 comments Download
M pkg/smoke/test/static_in_pieces_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/smoke/test/static_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jakemac
6 years, 3 months ago (2014-09-18 21:15:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm, I'm ok updating the pubspec/changelog and releasing this today. It should be OK to ...
6 years, 3 months ago (2014-09-18 21:24:07 UTC) #3
jakemac
6 years, 3 months ago (2014-09-18 22:03:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 40469 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698