pkg/smoke/lib/mirrors.dart - Issue 583803002: fix toString calls on Type objects in smoke

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/smoke/lib/mirrors.dart

Issue 583803002: fix toString calls on Type objects in smoke (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix typo Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/smoke/lib/mirrors.dart

diff --git a/pkg/smoke/lib/mirrors.dart b/pkg/smoke/lib/mirrors.dart

index 87071c9f15edffefe0139b412de71e7cac84b59c..29742afd4bb69a9a984f362b718050d4c5082a4e 100644

--- a/pkg/smoke/lib/mirrors.dart

+++ b/pkg/smoke/lib/mirrors.dart

@@ -34,7 +34,7 @@ class ReflectiveObjectAccessorService implements ObjectAccessorService {

{Map namedArgs, bool adjust: false}) {

var receiverMirror;

var method;

- if (receiver is Type) {

+ if (receiver is Type && methodName != #toString) {

receiverMirror = reflectType(receiver);

method = receiverMirror.declarations[methodName];

} else {

« no previous file with comments | « pkg/smoke/CHANGELOG.md ('k') | pkg/smoke/lib/static.dart » ('j') | no next file with comments »