pkg/smoke/lib/static.dart - Issue 583803002: fix toString calls on Type objects in smoke

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/smoke/lib/static.dart

Issue 583803002: fix toString calls on Type objects in smoke (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix typo Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/smoke/lib/static.dart

diff --git a/pkg/smoke/lib/static.dart b/pkg/smoke/lib/static.dart

index f7f74286974c8b5c24262934cbe34662b5f12f8a..33f25da6deb08839b1f9d92372951bcf661a9f65 100644

--- a/pkg/smoke/lib/static.dart

+++ b/pkg/smoke/lib/static.dart

@@ -116,7 +116,7 @@ class GeneratedObjectAccessorService implements ObjectAccessorService {

invoke(object, Symbol name, List args, {Map namedArgs, bool adjust: false}) {

var method;

- if (object is Type) {

+ if (object is Type && name != #toString) {

var classMethods = _staticMethods[object];

method = classMethods == null ? null : classMethods[name];

} else {

« no previous file with comments | « pkg/smoke/lib/mirrors.dart ('k') | pkg/smoke/pubspec.yaml » ('j') | no next file with comments »