GN: Complete static libs can't depend on static libs

GN: Complete static libs can't depend on static libs

Trying to use ar to put a static lib inside a complete static lib doesn't
work. GN should enforce and document this restriction.

BUG=None
TEST=gn_unittests, including new test for this case.
R=brettw

Committed: https://crrev.com/a6fa71420697c9376723b8c7f800c8670f40ea1e
Cr-Commit-Position: refs/heads/master@{#295609}

[brettw, 2014-09-18 19:51:25]

https://codereview.chromium.org/582863002/diff/1/tools/gn/target.cc
File tools/gn/target.cc (right):

https://codereview.chromium.org/582863002/diff/1/tools/gn/target.cc#newcode367
tools/gn/target.cc:367: for (DepsIterator iter(this); !iter.done();
iter.Advance()) {
I think you'll also need to check inherited_libraries here (make sure that's
populated by the time this function is called, since it also happens in
OnResolved). This will happen if there's a dependency on a source set that in
turn depends on a static library

[Chris Masone, 2014-09-18 20:32:43]

https://codereview.chromium.org/582863002/diff/1/tools/gn/target.cc
File tools/gn/target.cc (right):

https://codereview.chromium.org/582863002/diff/1/tools/gn/target.cc#newcode367
tools/gn/target.cc:367: for (DepsIterator iter(this); !iter.done();
iter.Advance()) {
On 2014/09/18 19:51:24, brettw wrote:
> I think you'll also need to check inherited_libraries here (make sure that's
> populated by the time this function is called, since it also happens in
> OnResolved). This will happen if there's a dependency on a source set that in
> turn depends on a static library

Done.

[brettw, 2014-09-18 23:02:12]

lgtm

[Chris Masone, 2014-09-18 23:02:33]

The CQ bit was checked by cmasone@chromium.org

[commit-bot: I haz the power, 2014-09-18 23:04:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/582863002/20001

[commit-bot: I haz the power, 2014-09-18 23:47:48]

Committed patchset #2 (id:20001) as 85205c089ffd519999b126038ddbcf290b2d759f

[commit-bot: I haz the power, 2014-09-18 23:48:39]

Patchset 2 (id:??) landed as
https://crrev.com/a6fa71420697c9376723b8c7f800c8670f40ea1e
Cr-Commit-Position: refs/heads/master@{#295609}