GN: Complete static libs can't depend on static libs

tools/gn/target_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/gn/build_settings.h"
 #include "tools/gn/config.h"
 #include "tools/gn/settings.h"
 #include "tools/gn/target.h"
 #include "tools/gn/test_with_scope.h"
@@ skipping 207 matching lines @@
   EXPECT_EQ(1u, b_inherited.size());
   EXPECT_TRUE(b_inherited.IndexOf(&c) != static_cast<size_t>(-1));
 
   // A should have B in its inherited libs, but not any others (the complete
   // static library will include the source set).
   const UniqueVector<const Target*>& a_inherited = a.inherited_libraries();
   EXPECT_EQ(1u, a_inherited.size());
   EXPECT_TRUE(a_inherited.IndexOf(&b) != static_cast<size_t>(-1));
 }
 
+TEST(Target, InheritCompleteStaticLibNoDirectStaticLibDeps) {
+  TestWithScope setup;
+  Err err;
+
+  // Create a dependency chain:
+  //   A (complete static lib) -> B (static lib)
+  Target a(setup.settings(), Label(SourceDir("//foo/"), "a"));
+  a.set_output_type(Target::STATIC_LIBRARY);
+  a.visibility().SetPublic();
+  a.set_complete_static_lib(true);
+  a.SetToolchain(setup.toolchain());
+  Target b(setup.settings(), Label(SourceDir("//foo/"), "b"));
+  b.set_output_type(Target::STATIC_LIBRARY);
+  b.visibility().SetPublic();
+  b.SetToolchain(setup.toolchain());
+
+  a.public_deps().push_back(LabelTargetPair(&b));
+  ASSERT_TRUE(b.OnResolved(&err));
+  ASSERT_FALSE(a.OnResolved(&err));
+}
+
+TEST(Target, InheritCompleteStaticLibNoIheritedStaticLibDeps) {
+  TestWithScope setup;
+  Err err;
+
+  // Create a dependency chain:
+  //   A (complete static lib) -> B (source set) -> C (static lib)
+  Target a(setup.settings(), Label(SourceDir("//foo/"), "a"));
+  a.set_output_type(Target::STATIC_LIBRARY);
+  a.visibility().SetPublic();
+  a.set_complete_static_lib(true);
+  a.SetToolchain(setup.toolchain());
+  Target b(setup.settings(), Label(SourceDir("//foo/"), "b"));
+  b.set_output_type(Target::SOURCE_SET);
+  b.visibility().SetPublic();
+  b.SetToolchain(setup.toolchain());
+  Target c(setup.settings(), Label(SourceDir("//foo/"), "c"));
+  c.set_output_type(Target::STATIC_LIBRARY);
+  c.visibility().SetPublic();
+  c.SetToolchain(setup.toolchain());
+
+  a.public_deps().push_back(LabelTargetPair(&b));
+  b.public_deps().push_back(LabelTargetPair(&c));
+
+  ASSERT_TRUE(c.OnResolved(&err));
+  ASSERT_TRUE(b.OnResolved(&err));
+  ASSERT_FALSE(a.OnResolved(&err));
+}
+
 TEST(Target, GetComputedOutputName) {
   TestWithScope setup;
   Err err;
 
   // Basic target with no prefix (executable type tool in the TestWithScope has
   // no prefix) or output name.
   Target basic(setup.settings(), Label(SourceDir("//foo/"), "bar"));
   basic.set_output_type(Target::EXECUTABLE);
   basic.SetToolchain(setup.toolchain());
   ASSERT_TRUE(basic.OnResolved(&err));
@@ skipping 185 matching lines @@
   // Depending on the forward target should apply the config.
   Target dep_on_forward(setup.settings(), Label(SourceDir("//a/"), "dof"));
   dep_on_forward.set_output_type(Target::SOURCE_SET);
   dep_on_forward.visibility().SetPublic();
   dep_on_forward.SetToolchain(setup.toolchain());
   dep_on_forward.private_deps().push_back(LabelTargetPair(&forward));
   ASSERT_TRUE(dep_on_forward.OnResolved(&err));
   ASSERT_EQ(1u, dep_on_forward.configs().size());
   EXPECT_EQ(&pub_config, dep_on_forward.configs()[0].ptr);
 }