tools/gn/target.h - Issue 582863002: GN: Complete static libs can't depend on static libs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target.h

Issue 582863002: GN: Complete static libs can't depend on static libs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add check for inherited static libraries as well Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/target.h

diff --git a/tools/gn/target.h b/tools/gn/target.h

index 9dd306420a4f1c9942d6a7e436fa9093458d6dc2..9d4b4bee45bfe7027f9f8ac55cdabdb225ba93af 100644

--- a/tools/gn/target.h

+++ b/tools/gn/target.h

@@ -244,6 +244,7 @@ class Target : public Item {

// Validates the given thing when a target is resolved.

bool CheckVisibility(Err* err) const;

bool CheckTestonly(Err* err) const;

+ bool CheckNoNestedStaticLibs(Err* err) const;

OutputType output_type_;

std::string output_name_;

« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | no next file with comments »