Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: tools/gn/target.h

Issue 582863002: GN: Complete static libs can't depend on static libs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add check for inherited static libraries as well Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_TARGET_H_ 5 #ifndef TOOLS_GN_TARGET_H_
6 #define TOOLS_GN_TARGET_H_ 6 #define TOOLS_GN_TARGET_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 void PullForwardedDependentConfigs(); 237 void PullForwardedDependentConfigs();
238 void PullForwardedDependentConfigsFrom(const Target* from); 238 void PullForwardedDependentConfigsFrom(const Target* from);
239 void PullRecursiveHardDeps(); 239 void PullRecursiveHardDeps();
240 240
241 // Fills the link and dependency output files when a target is resolved. 241 // Fills the link and dependency output files when a target is resolved.
242 void FillOutputFiles(); 242 void FillOutputFiles();
243 243
244 // Validates the given thing when a target is resolved. 244 // Validates the given thing when a target is resolved.
245 bool CheckVisibility(Err* err) const; 245 bool CheckVisibility(Err* err) const;
246 bool CheckTestonly(Err* err) const; 246 bool CheckTestonly(Err* err) const;
247 bool CheckNoNestedStaticLibs(Err* err) const;
247 248
248 OutputType output_type_; 249 OutputType output_type_;
249 std::string output_name_; 250 std::string output_name_;
250 std::string output_extension_; 251 std::string output_extension_;
251 252
252 FileList sources_; 253 FileList sources_;
253 bool all_headers_public_; 254 bool all_headers_public_;
254 FileList public_headers_; 255 FileList public_headers_;
255 bool check_includes_; 256 bool check_includes_;
256 bool complete_static_lib_; 257 bool complete_static_lib_;
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 }; 313 };
313 #elif defined(COMPILER_MSVC) 314 #elif defined(COMPILER_MSVC)
314 inline size_t hash_value(const Target* t) { 315 inline size_t hash_value(const Target* t) {
315 return reinterpret_cast<size_t>(t); 316 return reinterpret_cast<size_t>(t);
316 } 317 }
317 #endif // COMPILER... 318 #endif // COMPILER...
318 319
319 } // namespace BASE_HASH_NAMESPACE 320 } // namespace BASE_HASH_NAMESPACE
320 321
321 #endif // TOOLS_GN_TARGET_H_ 322 #endif // TOOLS_GN_TARGET_H_
OLDNEW
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698