Issue 5798002: Provide baseline for new GC infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5798002: Provide baseline for new GC infrastructure. (Closed)

Created:
10 years ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Provide baseline for new GC infrastructure. This is another version of http://codereview.chromium.org/5745005/. Instead of using conditional compilation with BASELINE_GC define this one uses FLAG_new_gc. I also addressed issue Vitaly noticed.

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -52 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	3 chunks	+14 lines, -3 lines	0 comments	Download
M	src/heap-inl.h	View	4 chunks	+12 lines, -1 line	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	2 chunks	+24 lines, -18 lines	1 comment	Download
M	src/ia32/ic-ia32.cc	View	1 chunk	+11 lines, -9 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+11 lines, -7 lines	0 comments	Download
M	src/mark-compact.cc	View	3 chunks	+9 lines, -1 line	1 comment	Download
M	src/objects.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+11 lines, -8 lines	0 comments	Download
M	src/spaces.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/spaces.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/spaces-inl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-spaces.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years ago (2010-12-13 19:58:28 UTC) #2

LGTM.

http://codereview.chromium.org/5798002/diff/1/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/5798002/diff/1/src/ia32/codegen-ia32.cc#newcod...
src/ia32/codegen-ia32.cc:9637: int delta_to_record_write = 0x0001;
Why is this suddenly an unnamed constant?

http://codereview.chromium.org/5798002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/5798002/diff/1/src/mark-compact.cc#newcode2358
src/mark-compact.cc:2358: if (!FLAG_new_gc &&
Heap::map_space()->NeedsCompaction(live_maps)) {
Shouldnt this be !FLAG_never_compact.  Looks a little like a bug in the old GC.

Expand Messages | Collapse Messages