Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 5798002: Provide baseline for new GC infrastructure. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/stub-cache-ia32.cc
diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc
index 352eae1f927577d815d76c7089df232c6dfdb627..111844c207500bb8feb5ba963bc5c42b38054326 100644
--- a/src/ia32/stub-cache-ia32.cc
+++ b/src/ia32/stub-cache-ia32.cc
@@ -1503,19 +1503,23 @@ MaybeObject* CallStubCompiler::CompileArrayPushCall(Object* object,
__ mov(ecx, Operand(esp, argc * kPointerSize));
__ mov(Operand(edx, 0), ecx);
- // Check if value is a smi.
- __ test(ecx, Immediate(kSmiTagMask));
- __ j(not_zero, &with_write_barrier);
+ if (!FLAG_new_gc) {
+ // Check if value is a smi.
+ __ test(ecx, Immediate(kSmiTagMask));
+ __ j(not_zero, &with_write_barrier);
+ }
__ bind(&exit);
__ ret((argc + 1) * kPointerSize);
- __ bind(&with_write_barrier);
+ if (!FLAG_new_gc) {
+ __ bind(&with_write_barrier);
- __ InNewSpace(ebx, ecx, equal, &exit);
+ __ InNewSpace(ebx, ecx, equal, &exit);
- __ RecordWriteHelper(ebx, edx, ecx);
- __ ret((argc + 1) * kPointerSize);
+ __ RecordWriteHelper(ebx, edx, ecx);
+ __ ret((argc + 1) * kPointerSize);
+ }
__ bind(&attempt_to_grow_elements);
if (!FLAG_inline_new) {

Powered by Google App Engine
This is Rietveld 408576698