Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: src/heap.cc

Issue 5798002: Provide baseline for new GC infrastructure. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap.h ('k') | src/heap-inl.h » ('j') | src/ia32/codegen-ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index 0497ad5f6a3d0b12ff72fbf94c6c61f43f8dab4b..d782d6304784d7cffe37d8038a56c9d6fab684c0 100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -226,6 +226,7 @@ int Heap::GcSafeSizeOfOldObject(HeapObject* object) {
int Heap::GcSafeSizeOfOldObjectWithEncodedMap(HeapObject* object) {
+ ASSERT(!FLAG_new_gc); // Should not be used in new GC.
ASSERT(!Heap::InNewSpace(object)); // Code only works for old objects.
ASSERT(MarkCompactCollector::are_map_pointers_encoded());
uint32_t marker = Memory::uint32_at(object->address());
@@ -3984,9 +3985,14 @@ void Heap::Verify() {
new_space_.Verify();
- VerifyPointersAndDirtyRegionsVisitor dirty_regions_visitor;
- old_pointer_space_->Verify(&dirty_regions_visitor);
- map_space_->Verify(&dirty_regions_visitor);
+ if (!FLAG_new_gc) {
+ VerifyPointersAndDirtyRegionsVisitor dirty_regions_visitor;
+ old_pointer_space_->Verify(&dirty_regions_visitor);
+ map_space_->Verify(&dirty_regions_visitor);
+ } else {
+ old_pointer_space_->Verify(&visitor);
+ map_space_->Verify(&visitor);
+ }
VerifyPointersUnderWatermark(old_pointer_space_,
&IteratePointersInDirtyRegion);
@@ -4207,6 +4213,11 @@ uint32_t Heap::IterateDirtyRegions(
Address area_end,
DirtyRegionCallback visit_dirty_region,
ObjectSlotCallback copy_object_func) {
+ if (FLAG_new_gc) {
+ visit_dirty_region(area_start, area_end, copy_object_func);
+ return Page::kAllRegionsDirtyMarks;
+ }
+
uint32_t newmarks = 0;
uint32_t mask = 1;
« no previous file with comments | « src/heap.h ('k') | src/heap-inl.h » ('j') | src/ia32/codegen-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698