Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 577593003: Revert of removing GrDrawEffect (Closed)

Created:
6 years, 3 months ago by joshua.litt
Modified:
6 years, 3 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gp3
Project:
skia
Visibility:
Public.

Description

Revert of removing GrDrawEffect (patchset #4 id:60001 of https://codereview.chromium.org/571163002/) Reason for revert: reverting to unblock another revert Original issue's description: > removing GrDrawEffect > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/8ddbe8b9366c8c59c4fb55f01f253de8a0b37d6e TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/08da4f22d790cfc51bbeb10b4b84dab49cf0eaec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+735 lines, -687 lines) Patch
M include/gpu/GrBackendEffectFactory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A include/gpu/GrDrawEffect.h View 1 chunk +47 lines, -0 lines 0 comments Download
M include/gpu/GrEffect.h View 2 chunks +7 lines, -5 lines 0 comments Download
M include/gpu/GrTBackendEffectFactory.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/core/SkXfermode.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 9 chunks +16 lines, -16 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 2 chunks +11 lines, -14 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 5 chunks +16 lines, -14 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 13 chunks +28 lines, -28 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 5 chunks +17 lines, -17 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 32 chunks +74 lines, -79 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 9 chunks +22 lines, -21 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 15 chunks +36 lines, -36 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 10 chunks +26 lines, -26 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 11 chunks +26 lines, -26 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 10 chunks +19 lines, -18 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 8 chunks +26 lines, -26 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 8 chunks +26 lines, -26 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 4 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLEffect.h View 4 chunks +10 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 2 chunks +7 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.h View 5 chunks +11 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 19 chunks +88 lines, -88 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
joshua.litt
Created Revert of removing GrDrawEffect
6 years, 3 months ago (2014-09-16 14:13:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577593003/1
6 years, 3 months ago (2014-09-16 14:14:47 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-16 14:14:48 UTC) #3
egdaniel
lgtm
6 years, 3 months ago (2014-09-16 14:15:39 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 14:17:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 08da4f22d790cfc51bbeb10b4b84dab49cf0eaec

Powered by Google App Engine
This is Rietveld 408576698