Make ServiceWorkerFetchRequest and ServiceWorkerResponse header maps case insensitive

Make ServiceWorkerFetchRequest and ServiceWorkerResponse header maps case insensitive

When storing headers in a map the map should be case insensitive (like HTTPHeaderMap in Blink) so that headers can be easily searched for and coalesced when necessary.

BUG=392621
Committed: https://crrev.com/f96d19ba7ea5be53ece63b9f6da963aaba2039c2
Cr-Commit-Position: refs/heads/master@{#296387}

[jkarlin, 2014-09-18 16:52:07]

jkarlin@chromium.org changed reviewers:
+ michaeln@chromium.org

[jkarlin, 2014-09-18 16:52:09]

Thanks!

[jsbell, 2014-09-22 20:55:04]

jsbell@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2014-09-22 20:55:04]

lgtm, FWIW

Can you add a trivial unit test that does a colliding insert (e.g.
"content-type" and "Content-Type") and a case-insensitive lookup in a SWHM, just
to ensure the behavior in case the type ever gets redefined? (I didn't see one
added in this CL.)

Will need an ipc/ OWNERS review (as well as a content/*/service_workers/ OWNERS
stamp).

[jkarlin, 2014-09-23 12:10:09]

On 2014/09/22 20:55:04, jsbell wrote:
> lgtm, FWIW
> 
> Can you add a trivial unit test that does a colliding insert (e.g.
> "content-type" and "Content-Type") and a case-insensitive lookup in a SWHM,
just
> to ensure the behavior in case the type ever gets redefined? (I didn't see one
> added in this CL.)

Good idea, done!

> 
> Will need an ipc/ OWNERS review (as well as a content/*/service_workers/
OWNERS
> stamp).

[jkarlin, 2014-09-23 12:12:57]

jkarlin@chromium.org changed reviewers:
+ horo@chromium.org, tsepez@chromium.org

[jkarlin, 2014-09-23 12:12:57]

Thanks jsbell!

horo: please review service_worker/
tsepez: please review ipc/ 
jam: please review content/common/* and content/renderer/*

[Tom Sepez, 2014-09-23 18:01:04]

LGTM otherwise.

https://codereview.chromium.org/576973004/diff/60001/ipc/ipc_message_utils.h
File ipc/ipc_message_utils.h (right):

https://codereview.chromium.org/576973004/diff/60001/ipc/ipc_message_utils.h#...
ipc/ipc_message_utils.h:367: template <class K, class V, class C>
while we're at it, do we want to add a 4th parameter |class A| to cover the case
where someone makes a map with a custom allocator, since std::map is spec'd with
4 params?

[Tom Sepez, 2014-09-23 18:07:08]

> while we're at it, do we want to add a 4th parameter |class A| to cover the
case
> where someone makes a map with a custom allocator, since std::map is spec'd
with
> 4 params?
Alternatively, feel free to land it as-is, and I'll clean up all the missing
parameters in ParamTraits for std:: types as a follow-up exercise.

[jkarlin, 2014-09-23 18:35:48]

https://codereview.chromium.org/576973004/diff/60001/ipc/ipc_message_utils.h
File ipc/ipc_message_utils.h (right):

https://codereview.chromium.org/576973004/diff/60001/ipc/ipc_message_utils.h#...
ipc/ipc_message_utils.h:367: template <class K, class V, class C>
On 2014/09/23 18:01:03, Tom Sepez wrote:
> while we're at it, do we want to add a 4th parameter |class A| to cover the
case
> where someone makes a map with a custom allocator, since std::map is spec'd
with
> 4 params?

Done.

[horo, 2014-09-24 02:18:30]

lgtm

[jkarlin, 2014-09-24 11:05:12]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-24 11:06:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/576973004/100001

[commit-bot: I haz the power, 2014-09-24 11:42:44]

Committed patchset #6 (id:100001) as e32b62d4b23bcc0a118d16695ff4136a7df59cd9

[commit-bot: I haz the power, 2014-09-24 11:43:24]

Patchset 6 (id:??) landed as
https://crrev.com/f96d19ba7ea5be53ece63b9f6da963aaba2039c2
Cr-Commit-Position: refs/heads/master@{#296387}