Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 576973004: Make ServiceWorkerFetchRequest and ServiceWorkerResponse header maps case insensitive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses comment from PS4 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc
index 2b57e74dffc56cc73c3c0735c4bb7ba34f1de91e..c09f4792fc36cdc440017223c56fe1b6b4eaee9c 100644
--- a/content/browser/service_worker/service_worker_url_request_job.cc
+++ b/content/browser/service_worker/service_worker_url_request_job.cc
@@ -416,14 +416,14 @@ void ServiceWorkerURLRequestJob::DidDispatchFetchEvent(
void ServiceWorkerURLRequestJob::CreateResponseHeader(
int status_code,
const std::string& status_text,
- const std::map<std::string, std::string>& headers) {
+ const ServiceWorkerHeaderMap& headers) {
// TODO(kinuko): If the response has an identifier to on-disk cache entry,
// pull response header from the disk.
std::string status_line(
base::StringPrintf("HTTP/1.1 %d %s", status_code, status_text.c_str()));
status_line.push_back('\0');
http_response_headers_ = new net::HttpResponseHeaders(status_line);
- for (std::map<std::string, std::string>::const_iterator it = headers.begin();
+ for (ServiceWorkerHeaderMap::const_iterator it = headers.begin();
it != headers.end();
++it) {
std::string header;
@@ -444,9 +444,8 @@ void ServiceWorkerURLRequestJob::CommitResponseHeader() {
void ServiceWorkerURLRequestJob::DeliverErrorResponse() {
// TODO(falken): Print an error to the console of the ServiceWorker and of
// the requesting page.
- CreateResponseHeader(500,
- "Service Worker Response Error",
- std::map<std::string, std::string>());
+ CreateResponseHeader(
+ 500, "Service Worker Response Error", ServiceWorkerHeaderMap());
CommitResponseHeader();
}

Powered by Google App Engine
This is Rietveld 408576698