Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: content/browser/service_worker/service_worker_cache.cc

Issue 576973004: Make ServiceWorkerFetchRequest and ServiceWorkerResponse header maps case insensitive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses comment from PS4 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_cache.cc
diff --git a/content/browser/service_worker/service_worker_cache.cc b/content/browser/service_worker/service_worker_cache.cc
index 2fb5216d8f19a7c1ccd4ea561e894b3648adc446..6013d827f80c43f2c5ceb3f6be5e6b7b47ab125e 100644
--- a/content/browser/service_worker/service_worker_cache.cc
+++ b/content/browser/service_worker/service_worker_cache.cc
@@ -248,8 +248,7 @@ void PutDidCreateEntry(scoped_ptr<ServiceWorkerFetchRequest> request,
headers.set_status_code(response->status_code);
headers.set_status_text(response->status_text);
- for (std::map<std::string, std::string>::const_iterator it =
- request->headers.begin();
+ for (ServiceWorkerHeaderMap::const_iterator it = request->headers.begin();
it != request->headers.end();
++it) {
ServiceWorkerRequestResponseHeaders::HeaderMap* header_map =
@@ -258,8 +257,7 @@ void PutDidCreateEntry(scoped_ptr<ServiceWorkerFetchRequest> request,
header_map->set_value(it->second);
}
- for (std::map<std::string, std::string>::const_iterator it =
- response->headers.begin();
+ for (ServiceWorkerHeaderMap::const_iterator it = response->headers.begin();
it != response->headers.end();
++it) {
ServiceWorkerRequestResponseHeaders::HeaderMap* header_map =
@@ -390,7 +388,7 @@ void MatchDidReadHeaderData(
new ServiceWorkerResponse(request->url,
headers->status_code(),
headers->status_text(),
- std::map<std::string, std::string>(),
+ ServiceWorkerHeaderMap(),
""));
for (int i = 0; i < headers->response_headers_size(); ++i) {
@@ -904,11 +902,11 @@ void ServiceWorkerCache::KeysDidReadHeaders(
keys_context->out_keys->push_back(
ServiceWorkerFetchRequest(GURL(entry->GetKey()),
headers->method(),
- std::map<std::string, std::string>(),
+ ServiceWorkerHeaderMap(),
GURL(),
false));
- std::map<std::string, std::string>& req_headers =
+ ServiceWorkerHeaderMap& req_headers =
keys_context->out_keys->back().headers;
for (int i = 0; i < headers->request_headers_size(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698