content/browser/service_worker/service_worker_browsertest.cc - Issue 576973004: Make ServiceWorkerFetchRequest and ServiceWorkerResponse header maps case insensitive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 576973004: Make ServiceWorkerFetchRequest and ServiceWorkerResponse header maps case insensitive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses comment from PS4 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_test_helper.cc ('k') | content/browser/service_worker/service_worker_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index 3bd48947376f0342377b932249cbe2815f72c34b..34b09b2b93aca976378ca940dd343b88c1fdfec5 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -544,7 +544,7 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {

ServiceWorkerFetchRequest request(

embedded_test_server()->GetURL("/service_worker/empty.html"),

"GET",

- std::map<std::string, std::string>(),

+ ServiceWorkerHeaderMap(),

GURL(""),

false);

version_->SetStatus(ServiceWorkerVersion::ACTIVATED);

@@ -701,7 +701,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, FetchEvent_Response) {

ASSERT_EQ(SERVICE_WORKER_FETCH_EVENT_RESULT_RESPONSE, result);

EXPECT_EQ(301, response.status_code);

EXPECT_EQ("Moved Permanently", response.status_text);

- std::map<std::string, std::string> expected_headers;

+ ServiceWorkerHeaderMap expected_headers;

expected_headers["content-language"] = "fi";

expected_headers["content-type"] = "text/html; charset=UTF-8";

EXPECT_EQ(expected_headers, response.headers);