Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 575283003: mac: Don't show access Address Book prompt if user has any Autofill state. (Closed)

Created:
6 years, 3 months ago by erikchen
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Two small changes to Access Addres Book prompt. - Don't show access Address Book prompt if user has any Autofill state. - Eliminate flickering of the access Address Book prompt. BUG=414359 Committed: https://crrev.com/ca7fd5a44b5ce2ad379ec7dc54e14d0d00c83a8a Cr-Commit-Position: refs/heads/master@{#295573}

Patch Set 1 : #

Patch Set 2 : Add unit test. #

Patch Set 3 : Fix another unit test. Fix some broken (unused) logic in that unit test. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 2 chunks +10 lines, -6 lines 1 comment Download
M components/autofill/core/browser/personal_data_manager_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
erikchen
estade: Please review.
6 years, 3 months ago (2014-09-18 00:46:22 UTC) #4
erikchen
estade: Please review.
6 years, 3 months ago (2014-09-18 00:46:23 UTC) #5
erikchen
Oops, sorry for the double email. rietvald fail. It turned my new lines into email ...
6 years, 3 months ago (2014-09-18 00:47:39 UTC) #6
Evan Stade
lgtm, but can you add a test?
6 years, 3 months ago (2014-09-18 01:17:53 UTC) #7
erikchen
added test.
6 years, 3 months ago (2014-09-18 18:09:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575283003/40001
6 years, 3 months ago (2014-09-18 18:10:38 UTC) #10
Evan Stade
On 2014/09/18 18:10:38, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 3 months ago (2014-09-18 18:30:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/15146)
6 years, 3 months ago (2014-09-18 19:37:55 UTC) #13
erikchen
estade: Fixed another test. Fixed some broken (unused) logic in that test class. https://codereview.chromium.org/575283003/diff/60001/components/autofill/core/browser/autofill_manager_unittest.cc File ...
6 years, 3 months ago (2014-09-18 21:02:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575283003/60001
6 years, 3 months ago (2014-09-18 21:04:22 UTC) #16
Evan Stade
On 2014/09/18 21:04:22, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 3 months ago (2014-09-18 21:08:36 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001) as 6d4b0b52b9492819268c145130ec863677b4cea6
6 years, 3 months ago (2014-09-18 21:59:40 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 22:00:41 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ca7fd5a44b5ce2ad379ec7dc54e14d0d00c83a8a
Cr-Commit-Position: refs/heads/master@{#295573}

Powered by Google App Engine
This is Rietveld 408576698