components/autofill/core/browser/personal_data_manager_mac.mm - Issue 575283003: mac: Don't show access Address Book prompt if user has any Autofill state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager_mac.mm

Issue 575283003: mac: Don't show access Address Book prompt if user has any Autofill state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another unit test. Fix some broken (unused) logic in that unit test. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_manager_unittest.cc ('K') | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager_mac.mm

diff --git a/components/autofill/core/browser/personal_data_manager_mac.mm b/components/autofill/core/browser/personal_data_manager_mac.mm

index 4080d3c66c9f66eeea42e8b493eb4f9398b89893..c6f8eef8b0205bce729cdcf3c88c53aed5e7530b 100644

--- a/components/autofill/core/browser/personal_data_manager_mac.mm

+++ b/components/autofill/core/browser/personal_data_manager_mac.mm

@@ -363,6 +363,11 @@ bool PersonalDataManager::AccessAddressBook() {

bool PersonalDataManager::ShouldShowAccessAddressBookSuggestion(

AutofillType type) {

+ // Don't show the access Address Book prompt if the user has built up any

+ // Autofill state.

+ if (!web_profiles_.empty())

+ return false;

if (!enabled_pref_->GetValue())

return false;